Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename single changelog file #2435

Merged
merged 1 commit into from
Nov 17, 2023
Merged

Rename single changelog file #2435

merged 1 commit into from
Nov 17, 2023

Conversation

StFroese
Copy link
Member

@StFroese StFroese commented Oct 27, 2023

Changelog file has wrong name. Should be bugfix.rst and not bug.rst otherwise it won't get rendered by towncrier

Tobychev
Tobychev previously approved these changes Oct 28, 2023
Copy link
Member

@maxnoe maxnoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This bugfix was already released (PR merged August 31, 0.20 released September 11).

So renaming it so it would be included in the next release's changelog is wrong.

Please remove the file and add the entry to the CHANGES.md file for the 0.20 release

Copy link

codecov bot commented Nov 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@6817199). Click here to learn what that means.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2435   +/-   ##
=======================================
  Coverage        ?   60.60%           
=======================================
  Files           ?        3           
  Lines           ?       33           
  Branches        ?        0           
=======================================
  Hits            ?       20           
  Misses          ?       13           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maxnoe maxnoe merged commit eee9b02 into main Nov 17, 2023
13 checks passed
@maxnoe maxnoe deleted the rename_change branch November 17, 2023 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants